The p-trap is the right buy for almost every modern sink, because it keeps the drain sealed, cleans up easier, and fits the vented layout homes already use better than the s-trap. The S-trap only wins when you are matching an older floor outlet or buying time before a proper vented correction. If the sink ties into a wall drain, the P-trap wins again by a wide margin.
Written by an editor focused on sink drain replacements, venting constraints, and the cleanup mess that follows the wrong trap shape.
Quick Verdict
The P-trap wins on the thing that matters most, ownership that stays quiet. It handles odor control, routine cleaning, and everyday repairs without turning the cabinet into a headache.
The S-trap looks simple on paper, and that is the trap. It fits a legacy floor-outlet layout, but the shape itself creates siphoning problems in modern installations, which means more cleanup, more odor risk, and more correction work later.
Decision checklist
- Choose P-trap for a wall-drain sink, which covers most kitchen and bath installs.
- Choose P-trap if under-sink storage matters and you want the cleanest access.
- Choose P-trap if you want the easiest repair path when a slip nut or washer loosens.
- Treat S-trap as a legacy match for an older floor drain, not a final design.
- Skip S-trap if the sink already gurgles, smells, or loses its seal after sitting unused.
Our Take
What is a P-Trap, and what is it used for?
A P-trap is the curved drain under a sink that holds a small amount of water in the bend. That water blocks sewer gas, and the horizontal outlet lines up with a vented wall drain, which is the normal setup for modern sinks.
That shape matters because it makes the repair predictable. When the trap clogs, leaks, or needs cleaning, the parts come apart in a way that a homeowner or plumber can service without reworking the whole drain. The trade-off is simple, the bend catches debris, so it needs occasional cleaning.
What is an S-Trap, and what is it used for?
An S-trap drops straight down before connecting to the drain line. That shape shows up in older homes and in quick fixes where the floor outlet stayed in place and nobody corrected the venting.
The problem is the shape itself. The vertical drop encourages siphoning, which strips away the water seal that keeps odor out of the room. That means an S-trap does not just look old, it behaves like an old problem that keeps coming back.
What’s the Difference Between a P-Trap and an S-Trap?
The difference is not cosmetic. A P-trap turns toward the wall after the seal, while an S-trap keeps going down and pulls too hard on its own water barrier.
Most guides recommend matching whatever shape is already there. That is wrong because the old shape is often the reason the sink smells, gurgles, or needs repeat attention. A trap is not just a pipe shape, it is the part that keeps the drain line livable.
Why Are P-Traps Preferred Over S-Traps?
P-traps win because they fit the drain path that actually works. They hold the seal better, service easier, and stay compatible with the parts and layouts homeowners run into most often.
The S-trap only makes sense as a legacy fit, and even then the right answer is correcting the drain path, not celebrating the old one. If the goal is fewer repair calls and less odor cleanup, the P-trap is the better choice.
Everyday Usability
A P-trap is the easier drain to live with. Weekly sink use throws soap, food scraps, grease, and hair into the line, and the P-trap handles that reality in a way that is easy to open, rinse, and reinstall.
The S-trap turns routine use into a nuisance when the seal gets pulled dry or the sink starts gurgling after a few hours of sitting idle. That is not a minor annoyance under a cabinet, it is the kind of smell or sound that sends someone back to the hardware aisle or into the plumbing app. Winner: P-trap.
Feature Depth
1. Sealing the Joint
The joint is where a lot of homeowner frustration starts. A P-trap usually gives you a cleaner, more straightforward slip-joint setup, which means fewer places for a washer to weep and fewer chances for a small leak to stain the cabinet floor.
An S-trap adds a vertical run and another pressure point in a layout that already fights the seal. One loose nut in that stack turns into cleanup, and cleanup under a sink always takes longer than the leak itself. Winner: P-trap.
Drain path and venting
A correct trap is about more than holding water. It has to match the way the drain is vented, and that is where the P-trap has the advantage in modern homes.
The S-trap lives on the wrong side of that logic. It draws water downward in a way that creates siphon trouble, which means the sink acts like the trap is working until the odor tells a different story. Winner: P-trap.
Repair access
P-traps stay friendly to repairs because the service points are reachable and obvious. If a clog forms, the trap usually comes apart without tearing into the wall or the floor connection.
S-traps make a simple repair feel bigger than it is. The layout itself becomes part of the problem, and that is a bad deal when the goal is a quick cleanup and a sink that goes back into service the same day. Winner: P-trap.
Physical Footprint
Under-sink space matters more than people expect. A P-trap leaves a more usable cabinet floor and keeps the plumbing tucked toward the back, which makes room for cleaners, a pull-out bin, or just easier access to the shutoff valves.
An S-trap claims the cabinet floor with a vertical drop that cuts into storage and complicates access. In a small vanity, that difference shows up every time someone reaches for a sponge or tries to fit a trash container under the sink. Winner: P-trap.
The Hidden Trade-Off
The cheap-looking choice is not always the cheap outcome. An S-trap looks like the quick fix because it follows the old line, but the savings disappear fast if it leaves odor complaints, repeat gurgling, or a future correction job.
P-traps usually ask for the better upfront layout, then pay that back with lower repair friction. That is the real trade-off here, spend a little attention on the right drain path now, or spend more time and money cleaning up the wrong one later. Winner: P-trap.
What Changes After Year One With This Matchup
Year one exposes the trap choice fast. A correct P-trap fades into the background, which is exactly what a sink drain should do.
An S-trap keeps asking for attention. The seal dries out after disuse, the cabinet smells after a drain cycle, and the owner starts reopening the underside to chase a problem that lives in the layout, not the hardware.
Parts availability also favors the P-trap over time. Slip-joint washers, extension pieces, and trap adapters are easy to source, so the normal repair stays normal. An S-trap does not improve with more parts on hand, because the core issue is the shape and the venting, not the shopping list. Winner: P-trap.
How It Fails
The P-trap fails in serviceable ways. A loose slip nut, a worn washer, or a clog in the bend creates a visible problem that is easy to trace and fix.
The S-trap fails at the design level. It loses the water seal, lets sewer gas creep back into the room, and turns a basic sink into a smell-and-sound problem that keeps returning until the drain path changes. That makes the S-trap harder to trust and harder to own. Winner: P-trap.
Who Should Skip This
Skip the S-trap if the sink drains into a wall and the goal is a final repair. It does not solve the real problem, it preserves it.
Skip the P-trap as a direct swap if the drain exits through the floor and no vented reroute is part of the plan. In that case, the answer is a drain correction, not a different bend under the sink.
Skip both as a lazy cosmetic fix when the real issue is venting. A plumber who corrects the layout does more for odor, serviceability, and cleanup than a pile of trap hardware ever will.
Value for Money
Value lives in the repair you do not have to repeat. The P-trap wins because it solves the common sink layout cleanly, keeps future maintenance simple, and reduces the odds of spending money on odor or drainage fixes later.
The S-trap looks like the cheaper alternative only when the homeowner ignores the correction it demands. That is a false bargain. The part may match the old line, but the ownership cost shows up in the callback, the smell, or the second trip to rebuild the drain. Winner: P-trap.
The Honest Truth
Most guides treat trap shape like a small detail. That is wrong. The trap shape decides whether the seal stays put, whether the cabinet stays dry, and whether the sink feels finished or temporary.
Best-fit scenario Buy a P-trap for a kitchen or bathroom sink that ties into a wall drain, needs easy cleanup, and shares cabinet space with cleaners or storage bins. Keep an S-trap only as a legacy match on a floor-drain setup while the venting or drain path gets corrected.
Final Verdict
Buy the P-trap for the common home repair. It is the standard choice for modern sink layouts, easier to clean, easier to service, and far better at keeping odor out of the cabinet.
Skip the S-trap unless you are dealing with an older floor outlet and using it as a temporary bridge to a proper correction. For most homeowners and first-time buyers, the P-trap is the better buy, the better repair, and the better maintenance choice.
Frequently Asked Questions
Can I replace an S-trap with a P-trap myself?
Yes, if the drain path supports a vented wall connection and the parts line up cleanly. If the drain exits the floor, the real fix is correcting the plumbing layout, not forcing a P-trap into the wrong geometry.
Why does an S-trap make a sink smell?
The vertical drop pulls water out of the trap seal. Once that water barrier is gone, sewer gas moves back into the room.
Which trap is easier to clean under the sink?
The P-trap is easier to clean. The bend is reachable, the slip joints come apart, and a clog stays local to the part you can service.
Is an S-trap ever the right final solution?
No, not for a modern vented sink. It belongs in legacy situations or as a temporary setup while the drain gets corrected.
What should a first-time homeowner buy for a standard sink repair?
A P-trap. It matches the common wall-drain setup, keeps maintenance simple, and avoids the odor and service problems tied to S-traps.
Why do some older homes still have S-traps?
Older drain layouts used them before modern venting standards took over. That does not make them the better choice for a new repair.
Does a P-trap stop sewer gas better than an S-trap?
Yes. The P-trap holds a stable water seal in the proper vented layout, which is the barrier that blocks sewer gas.
Should I keep the old trap if it still drains?
No. A trap that still drains but loses its seal or smells is not doing its job. Replace the layout with the correct trap shape and venting setup.